Skip to content

don't wipe build environment before building opam in install step of OCaml easyblock #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2024
Merged

don't wipe build environment before building opam in install step of OCaml easyblock #3443

merged 1 commit into from
Sep 12, 2024

Conversation

@boegel
Copy link
Member

@boegel boegel commented Sep 12, 2024 •
edited
Loading

(created using eb --new-pr)

Calling load_fake_module with purge=True implies wiping the build environment, and resetting it to what it was when eb was started.

That's especially problematic when EasyBuild is configured to use RPATH linking, since the RPATH wrappers that EasyBuild puts in place are then no longer used...

fixes #3247

@boegel boegel added the bug fix label Sep 12, 2024
@boegel boegel added this to the release after 4.9.3 milestone Sep 12, 2024
@boegel
Copy link
Member Author

boegel commented Sep 12, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="OCaml-4.14.0-GCC-11.3.0.eb OCaml-5.1.1-GCC-13.2.0.eb ocamlbuild-0.14.3-GCC-13.2.0.eb SNAPE-pooled-20150707-GCC-11.3.0.eb hevea-2.36-GCC-13.2.0.eb"

@boegelbot
Copy link

boegelbot commented Sep 12, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3443 EB_ARGS="OCaml-4.14.0-GCC-11.3.0.eb OCaml-5.1.1-GCC-13.2.0.eb ocamlbuild-0.14.3-GCC-13.2.0.eb SNAPE-pooled-20150707-GCC-11.3.0.eb hevea-2.36-GCC-13.2.0.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3443 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4853

Test results coming soon (I hope)...

- notification for comment with ID 2346159739 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

boegelbot commented Sep 12, 2024 •
edited by boegel
Loading

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS OCaml-4.14.0-GCC-11.3.0.eb
  • SUCCESS OCaml-5.1.1-GCC-13.2.0.eb
  • SUCCESS ocamlbuild-0.14.3-GCC-13.2.0.eb
  • SUCCESS SNAPE-pooled-20150707-GCC-11.3.0.eb
  • SUCCESS hevea-2.36-GCC-13.2.0.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/e69fa8467c8ee3fb225801a436767c6d for a full test report.

edit: this was using EasyBuild 4.9.x-develop, with RPATH disabled

@boegel
Copy link
Member Author

boegel commented Sep 12, 2024 •
edited
Loading

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OCaml-4.14.0-GCC-11.3.0.eb
  • SUCCESS OCaml-5.1.1-GCC-13.2.0.eb
  • SUCCESS ocamlbuild-0.14.3-GCC-13.2.0.eb
  • SUCCESS SNAPE-pooled-20150707-GCC-11.3.0.eb
  • SUCCESS hevea-2.36-GCC-13.2.0.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
node4005.donphan.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz, 1 x NVIDIA NVIDIA A2, 545.23.08, Python 3.6.8
See https://gist.github.com/boegel/c284b0f41ab49cf396d50ff844667709 for a full test report.

edit: also without RPATH

@boegel
Copy link
Member Author

boegel commented Sep 12, 2024 •
edited
Loading

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OCaml-4.14.0-GCC-11.3.0.eb
  • SUCCESS OCaml-5.1.1-GCC-13.2.0.eb
  • SUCCESS ocamlbuild-0.14.3-GCC-13.2.0.eb
  • SUCCESS SNAPE-pooled-20150707-GCC-11.3.0.eb
  • SUCCESS hevea-2.36-GCC-13.2.0.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
node4005.donphan.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz, 1 x NVIDIA NVIDIA A2, 545.23.08, Python 3.6.8
See https://gist.github.com/boegel/06adb10ff79962779a65f4580966e54b for a full test report.

edit: with RPATH, proving that this indeed fixes #3247

Micket
Micket approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit d9b1499 into easybuilders:develop Sep 12, 2024
@boegel boegel deleted the 20240912142714_new_pr_ocaml branch September 12, 2024 16:12
@boegel boegel modified the milestones: release after 4.9.3, 4.9.3 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

RPATH sanity check fails for OCaml

3 participants

@boegel @boegelbot @Micket